Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pass the OpenAI API Key to Crew() #4555

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: Pass the OpenAI API Key to Crew() #4555

merged 1 commit into from
Nov 13, 2024
+14 −1

Conversation

erichare
Copy link
Collaborator

This pull requests sets the OpenAI API Key as an environment variable and adds a new input to provide it in the hierarchical crew component

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 12, 2024
@erichare erichare requested a review from NadirJ November 12, 2024 23:55
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
@erichare erichare merged commit 335b649 into main Nov 13, 2024
36 of 37 checks passed
@erichare erichare deleted the bugfix-crewai-api-key branch November 13, 2024 00:05
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #4555 will degrade performances by 16.47%

Comparing bugfix-crewai-api-key (33b12eb) with main (01431ee)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bugfix-crewai-api-key Change
⚡ test_successful_run_with_input_type_text 454.8 ms 379 ms +20.02%
⚡ test_successful_run_with_output_type_any 455.9 ms 347.3 ms +31.29%
❌ test_successful_run_with_output_type_debug 444.3 ms 531.9 ms -16.47%

@erichare erichare linked an issue Nov 15, 2024 that may be closed by this pull request
Dynamic Agent template: OpenAI key error #4395
Closed
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@erichare @diogocabral
fix: Pass the OpenAI API Key to Crew() (langflow-ai#4555)
2921175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NadirJ NadirJ NadirJ approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic Agent template: OpenAI key error
2 participants
@erichare @NadirJ